-
Notifications
You must be signed in to change notification settings - Fork 740
pkg/util: Change check-dns init container image #1919
Conversation
The image currently used is busybox:1.28.0 which uses uclibc. This is causing nslookup to fail name resolution when it shouldn't in some environments. The version of busybox that uses glibc does not suffer the same problem. Related: docker-library/busybox#9 docker-library/busybox#27
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
@etcd-bot ok to test |
@lander2k2 |
@hongchaodeng
Sorry I can't give a more universally reproducible example. I did think this was related to a bug in uclibc related to nameserver search path length [1] but I've been unable to induce the error outside the VMware environment by manipulating the search path. :/ [1] https://mailman.uclibc-ng.org/pipermail/devel/2016-February/000775.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nit
@@ -346,7 +346,7 @@ func newEtcdPod(m *etcdutil.Member, initialCluster []string, clusterName, state, | |||
}, | |||
Spec: v1.PodSpec{ | |||
InitContainers: []v1.Container{{ | |||
Image: "busybox:1.28.0", | |||
Image: "busybox:1.28.0-glibc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment about the search path issue on VMWare environment and why use glibc instead?
Going to do a release later today. So I will merge this and add the comment myself. |
The image currently used is busybox:1.28.0 which uses uclibc. This is
causing nslookup to fail name resolution when it shouldn't in some
environments. The version of busybox that uses glibc does not suffer the
same problem.
Related:
docker-library/busybox#9
docker-library/busybox#27