Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revision based auto-compaction-retention #8098

Closed
clusc opened this issue Jun 14, 2017 · 8 comments
Closed

revision based auto-compaction-retention #8098

clusc opened this issue Jun 14, 2017 · 8 comments

Comments

@clusc
Copy link

clusc commented Jun 14, 2017

Hi,

Currently we are using the auto-compaction-retention parameter to compact etcd data every 24h. But given our spiky usage pattern(we are using etcd as distributed lock), this time based compaction policy doesn't work too well for us. Is there a revision-based auto-compaction policy that we can configure? Also, is there a metric for # of revision that we can watch on(I didn't find in the current exposed metrics)?

Thanks

@xiang90
Copy link
Contributor

xiang90 commented Jun 14, 2017

It makes sense. We will probably add it.

@clusc
Copy link
Author

clusc commented Jun 14, 2017

Thanks. Is there a workaround that we can do now to alleviate us from manually compacting every now and then? We are using etcd-operator, is this something that operator can help?

@xiang90
Copy link
Contributor

xiang90 commented Jun 14, 2017

@clusc Not really. It is all manual at the moment.

@xiang90
Copy link
Contributor

xiang90 commented Jun 14, 2017

@clusc

is there a metric for # of revision

revision is attached in every response header.

@clusc
Copy link
Author

clusc commented Jun 14, 2017

It doesn't for /metrics endpoint though right?

@xiang90
Copy link
Contributor

xiang90 commented Jun 14, 2017

@clusc No. You can add a debugging metrics for it if you wish. Open a pr, thanks.

@yudai
Copy link
Contributor

yudai commented Jun 17, 2017

I had the same idea and just crated a PR for it.
Still, compaction happens every 5 minutes, but I believe it should cover almost all environments.

@xiang90
Copy link
Contributor

xiang90 commented Jun 22, 2017

fixed by #8123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants