etcdctl: cluster-health supports forever flag #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fmt.Println("cluster may be unhealthy: failed to list members") | ||
| if forever { | ||
| time.Sleep(10 * time.Second) | ||
| continue |
There was a problem hiding this comment.
It continues to check err again. Is it supposed to list member again?
There was a problem hiding this comment.
this is a mistake. i moved this out of the for loop and added a todo.
cluster-health command supports checking the cluster health forever.
|
PTAL. This commits does not change any previous logic. The previous logic has some issues. But we should address them in another pull request I think. |
|
lgtm |
xiang90
added a commit
that referenced
this pull request
Aug 4, 2015
etcdctl: cluster-health supports forever flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster-health command supports checking the cluster health
forever.
Fix #2383