initial v3 demo #3248
initial v3 demo #3248
Conversation
xiang90
force-pushed
the
v3
branch
2 times, most recently
from
527bd6e
to
264b570
Compare
| @@ -208,6 +210,9 @@ func NewConfig() *config { | |||
| // version | |||
| fs.BoolVar(&cfg.printVersion, "version", false, "Print the version and exit") | |||
|
|
|||
| // demo flag | |||
| fs.BoolVar(&cfg.v3demo, "v3demo", false, "Enable v3 demo") | |||
There was a problem hiding this comment.
Can we have something that seems scarier? --enable-experimental-v3demo
|
Any reason the etcdctl doesn't just have a flag to enable the v3 api, changing the CLI params from those of v2? This would be more consistent with how you set up the server, also would allow for easier experimenting without having to build in another CLI tool. (I'm thinking if we ship experimental v3 features gated by feature flags in the CoreOS image, you don't want another CLI tool to bundle). |
|
@ecnahc515 Server and command line tool are different. We already have decent endpoint control on server side. We will end up with adding version prefix to the command line tool, which is ugly and worser than having the version separate in my opinion. If anyone holds very strong opinion on this, we might consider to combine them. In a word, I would like to have them as separate as possible at this point (demo). To answer your CoreOS question, we do not really expect users to try it out; we expect developers to try it out at this point. So we do not even need to ship the clt in CoreOS image. |
|
I think the best way for developers to try this out is running the demo on CoreOS, just behind a feature flag is all. I don't have a huge opinion one way or another either, just was curious. |
|
pretty nice. it is good overall. For CoreOS running, I think users should use etcd binary to test it out. This is much easier and controllable. |
| ### Experimental Flags | ||
|
|
||
| ##### -experimental-v3demo | ||
| + Enable experimental v3 demo API |
There was a problem hiding this comment.
can you add a link to docs
|
change v3etcdctl to etcdctlv3? |
|
@philips All fixed. |
|
I am merging this. I will iterate on this one quickly. |
A non-clustered version of v3 key API, which includes put, range, delete
It will also include a demo command line tool.
Will follow-up with txn support.
start etcd server with v3 demo
play with initial ctl
cd etcdctlv3 go build ./etcdctlv3 put foo bar foo bar ./etcdctlv3 put foo1 bar1 foo1 bar1 ./etcdctlv3 range foo foo bar ./etcdctlv3 range foo z_last foo bar foo1 bar1 ./etcdctlv3 delete-range foo key foo is deleted ./etcdctlv3 delete-range foo z_last range [foo, z_last) is deleted ./etcdctlv3 range foo z_last (empty)