improve in order key generation #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
force-pushed
the
sort
branch
2 times, most recently
from
2bc4854
to
32086e6
Compare
|
Note this breaks the API and previous behavior. I think it might be OK, since people should not rely on the naming (if they do, they already have done it wrong... they have to compare the created index to sort anyway) |
| @@ -423,13 +423,13 @@ curl -s 'http://127.0.0.1:2379/v2/keys/queue?recursive=true&sorted=true' | |||
| "nodes": [ | |||
| { | |||
| "createdIndex": 2, | |||
| "key": "/queue/2", | |||
| "key": "/queue/00000000000000000002", | |||
There was a problem hiding this comment.
i think we need to update the key field in create response too.
There was a problem hiding this comment.
good catch. i will change.
|
I agree that this change still provides the original guarantee. |
|
@yichengq Updated. PTAL. |
|
lgtm |
xiang90
added a commit
that referenced
this pull request
Aug 13, 2015
improve in order key generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating in order key that padding with 0 as its prefix.
It would be help to sort them lexicographically.