pkg/types: fix unwanted unescape in NewURLsMap #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failed. |
| } | ||
| for name, urls := range v { | ||
| if len(urls) == 0 || urls[0] == "" { | ||
| urlsm := make(map[string][]string) |
There was a problem hiding this comment.
can we simply copy https://golang.org/src/net/url/url.go?s=18971:19022#L680 and remove the unnecessary parts?
|
fix tests, and reference url.Parse to implement the function. PTAL. |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // +build go1.5 |
There was a problem hiding this comment.
Let us refer the original bug report in golang itself. Tell people why we only test this after go 1.5
|
LGTM |
We use url.ParseQuery to parse names-to-urls string, but it has side effect that unescape the string. If the initial-cluster string has ipv6 which contains `%25`, it will unescape it to `%` and make further url parse failed. Fix it by modifiying the parse process. Go1.4 doesn't support literal IPv6 address w/ zone in URI(golang/go#6530), so we only enable tests in Go1.5+.
yichengq
added a commit
that referenced
this pull request
Oct 5, 2015
pkg/types: fix unwanted unescape in NewURLsMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use url.ParseQuery to parse names-to-urls string, but it has side
effect that unescape the string. If the initial-cluster string has ipv6
which contains
%25, it will unescape it to%and make further urlparse failed.
Fix it by writing the parse process ourselves.