etcdctl: fix health check condition #3697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps to fix the condition to determine if a member is healthy.
BTW, when determine if the whole cluster if healthy, it assumes that cluster is healthy as long as there is _one_ member is healthy. Should we replace that condition to "iff _most_ of the members are healthy". If your answer is YES, I am glad to help fix this. (After all, I don't know the implementation of
health
endpoint, maybe all the member will response "false" if most of members are unhealthy)