etcdctl: fix health check condition #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqliang
changed the title
mqliang
changed the title
The health endpoint of a member indicates the cluster-wide heath. So the implementation is correct actually. Thanks for your fix! |
|
@mqliang Can you please update the commit message to |
mqliang
changed the title
|
@mqliang xiang means the git commit title. We always use this format: https://github.com/coreos/etcd/blob/master/CONTRIBUTING.md#format-of-the-commit-message |
mqliang
force-pushed
the
cluster-health
branch
from
58ee2da
to
b2d92de
Compare
|
Will this be back-ported? Does this mean that the current health check is not valid? |
|
@raoofm This does not affect any release version of etcd as far as I can see. I will double check. |
|
@raoofm But yes, we will back-port this anyway. |
xiang90
added a commit
that referenced
this pull request
Oct 18, 2015
etcdctl: fix health check condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps to fix the condition to determine if a member is healthy.
BTW, when determine if the whole cluster if healthy, it assumes that cluster is healthy as long as there is _one_ member is healthy. Should we replace that condition to "iff _most_ of the members are healthy". If your answer is YES, I am glad to help fix this. (After all, I don't know the implementation of
healthendpoint, maybe all the member will response "false" if most of members are unhealthy)