rafthttp: fix data races detected by go race detector #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiang90
commented
Oct 26, 2015
xiang90
commented
- fix the race in the test. fakeWriteFlushCloser is used by multiple routines without locking.
- stopped variable has data race. Removing it since the stop logic is actually unnecessary.
| wfc.written += len(p) | ||
| return len(p), wfc.err | ||
| } | ||
| func (wfc *fakeWriteFlushCloser) Flush() {} | ||
| func (wfc *fakeWriteFlushCloser) Close() error { | ||
| wfc.mu.Lock() | ||
| defer wfc.mu.Unlock() |
There was a problem hiding this comment.
add one empty line here as Write function does?
|
LGTM if it passes race detection. |
|
lgtm |
xiang90
added a commit
that referenced
this pull request
Oct 27, 2015
rafthttp: fix data races detected by go race detector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.