*: fix various data races detected by race detector #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| p, ok := t.peers[to] | ||
| t.mu.RUnlock() |
There was a problem hiding this comment.
mu is used to protect the remote and peer map, and i see g, ok := t.remotes[to] 10 lines below, so I think it needs this lock too.
There was a problem hiding this comment.
but when running, this cannot happen because we only AddRemote before sending messages.
There was a problem hiding this comment.
You can clean this up in the near future. I am trying to clean up the race detected by the race detector in the commit. Or you want me to go over the code?
There was a problem hiding this comment.
This is fine for this PR.
|
lgtm if CI passes. |
xiang90
added a commit
that referenced
this pull request
Oct 27, 2015
*: fix various data races detected by race detector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run etcd under high load in real env. No race is detected.
The races are detected by enabling race detector for integration test. But all of them happens at VERY low frequent (only happens when there is a cluster configuration change)