add etcdtop #3790
Merged
add etcdtop #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonboulle @yichengq etcd-top requires libcap-dev to be installed on travis and other CI since it introduces cgo. What do you think? Shall we just make it a separate thing or move this into etcd repo? |
|
It's probably easy enough to get libcap-dev on semaphore and just run the tests there. |
|
For Travis I think we can add an install step to stop it from doing the |
|
@jonboulle Personally, I think the runtime analysis tool worth official support. But I do not think we have full bandwidth to support it and keep it updated with v3 right now. |
xiang90
force-pushed
the
etcd-top
branch
3 times, most recently
from
b50db56
to
c7cdc05
Compare
|
Let's ship it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpcap tool for analyzing popular commands on a production etcd server.