client: fix goroutine leak in unreleased context #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @nordligulv . You can do: |
If headerTimeout is not zero then two context are created but only one is released. cancelCtx in this case is never released which leads to goroutine leak inside it.
korzha
changed the title
|
Done |
|
Thanks! LGTM |
xiang90
added a commit
that referenced
this pull request
Nov 27, 2015
client: fix goroutine leak in unreleased context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If headerTimeout is not zero then two contexts are created but only one is released.
cancelCtx in this case is never released which leads to goroutine leak inside it.