-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: fix data race when modify event in watchHub. #3972
Conversation
The event got from watchHub should be considered as readonly. To modify it, we first need to get a clone of it or there might be a data race.
Great - thanks @xiang90 Would it be possible to patch it to 2.2.2 release once this is merged? |
@wojtek-t Probably early next week. |
LGTM. |
thanks - can you please ping me then - I will update our dependency on etcd in k8s |
@wojtek-t sure. |
store: fix data race when modify event in watchHub.
@xiang90 - thanks a lot! |
@xiang90 could we get this change on a 2-series branch, I'm updating deps right now. |
@wojtek-t I will do the cherry picks today. And release tomorrow hopefully |
@xiang90 - thanks a lot! I guess release is not that urgent, since we have problems in unit tests, and for those we simply have etcd in our Godeps (for which I guess we don't need an official release). |
Cherry picked to https://github.com/coreos/etcd/tree/release-2.2 branch |
@xiang90 - thanks a lot for help! |
The event got from watchHub should be considered as readonly.
To modify it, we first need to get a clone of it or there might
be a data race.
Fix kubernetes/kubernetes#18437
/cc @gyuho @wojtek-t @timothysc