etcdserver: fix creating member dir #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a7e443d.
This commit fixes the issue of creating member dir before validating the configuration. When member dir exists, it indicates the local etcd process is a valid etcd member. So we should only create member dir after we finish configuration validation, joining validation or discovery validation.
|
Got it. LGTM. Thanks for fixing this! |
|
Sure, give me a sec. |
|
@xiang90 Just tested manually assigning errors and confirmed that it doesn't create directories when bootstrap fails. |
xiang90
added a commit
that referenced
this pull request
Dec 29, 2015
etcdserver: fix creating member dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gyuho I reverted your previous fix since that is a partial fix, which does not cover the discovery case.
I feel this is a easier way to fix the root problem. We should not create member dir before validation.