etcdctl: ignore value in updatedir command #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes coreos#4145. client.KeysAPI ignores value if SetOptions.Dir is true.
gyuho
force-pushed
the
fix_arg_update_dir
branch
from
c499ff1
to
dd02ec6
Compare
|
@xiang90 Tried this and worked: |
|
LGTM |
|
Thanks, will merge after CI passes. |
gyuho
added a commit
that referenced
this pull request
Jan 7, 2016
etcdctl: get only the first argument for updatedir
gyuho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4145.
client.KeysAPI ignores value if SetOptions.Dir is true.
/cc @xiang90