Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdctl: don't crash on duplicate role in user grant #5049

Merged
merged 2 commits into from
Apr 12, 2016
Merged

etcdctl: don't crash on duplicate role in user grant #5049

merged 2 commits into from
Apr 12, 2016

Conversation

heyitsanthony
Copy link
Contributor

No description provided.

@heyitsanthony
Copy link
Contributor Author

/cc @xiang90 @kciepluc

@xiang90
Copy link
Contributor

xiang90 commented Apr 12, 2016

So sever-side already returns duplicated role as an error? If yes, then lgtm.

@gyuho
Copy link
Contributor

gyuho commented Apr 12, 2016

lgtm.

@heyitsanthony
Copy link
Contributor Author

@xiang90 yeah, it already gets an error from https://github.com/coreos/etcd/blob/master/etcdserver/auth/auth.go#L466

@heyitsanthony heyitsanthony merged commit 095a755 into etcd-io:master Apr 12, 2016
@heyitsanthony heyitsanthony deleted the fix-grant-roles-existing branch April 13, 2016 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heyitsanthony @xiang90 @gyuho