-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix invalid access to backend struct #5144
Conversation
@@ -160,6 +160,8 @@ func (t *batchTx) commit(stop bool) { | |||
// commit the last tx | |||
if t.tx != nil { | |||
if t.pending == 0 && !stop { | |||
b.mu.RLock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this compile? t.backend.mu...
?
@gyuho Sorry! Will fix. |
Thanks. LGTM after that. Defer to @heyitsanthony |
lgtm |
This is actually still broken... I will try more... |
All fixed. PTAL. /cc @heyitsanthony |
@xiang90 seems like it's deadlocking on the reader lock now? |
@heyitsanthony Whoops... Forgot to check in the changes in backend.go. Now fixed. |
lgtm after fixing the commit titles |
Fix #5142