raft: do not panic when removing all the nodes from cluster #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ngaut @siddontang Probably you also want to port this to rust impl. |
|
@xiang90 Ok will write end-to-end tests for this. |
|
Low risk. Merging. |
tiancaiamao
added a commit
to tikv/tikv
that referenced
this pull request
May 17, 2016
tiancaiamao
added a commit
to tikv/tikv
that referenced
this pull request
May 17, 2016
BusyJay
pushed a commit
to tikv/raft-rs
that referenced
this pull request
Dec 19, 2017
siennathesane
pushed a commit
to shieldmaidens/pleiades
that referenced
this pull request
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5360.
@gyuho Can you add an etcdctl + etcd e23 restore test for this? Thanks!