Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: wait for snapshots before closing raft #5379

Merged
merged 1 commit into from
May 17, 2016
Merged

etcdserver: wait for snapshots before closing raft #5379

merged 1 commit into from
May 17, 2016

Conversation

heyitsanthony
Copy link
Contributor

Fixes #5374

Probably should be backported to 2.3?

@gyuho
Copy link
Contributor

gyuho commented May 17, 2016

LGTM. Sure, think we should backport this too? /cc @xiang90

@xiang90
Copy link
Contributor

xiang90 commented May 17, 2016

lgtm

@heyitsanthony heyitsanthony merged commit fb8d12a into etcd-io:master May 17, 2016
@gyuho
Copy link
Contributor

gyuho commented May 20, 2016

@heyitsanthony @xiang90 Can't backport this because 2.3 is before we have sync.WaitGroup https://github.com/coreos/etcd/blob/release-2.3/etcdserver/server.go#L205

@heyitsanthony
Copy link
Contributor Author

Looks like it depends on 4991cda and 08d8793.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heyitsanthony @gyuho @xiang90