etcd: fix refresh feature #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this needs backport? If so, can you do in separate commits to make it easy to backport? Thanks! |
|
Yes. We need to back-port. I will fix the broken tests first. |
xiang90
force-pushed
the
fix_refrsh
branch
2 times, most recently
from
5bd1039
to
d842eff
Compare
When using refresh, etcd store v2 watch is broken. Although with refresh store should not trigger current watchers, it should still add events into the watchhub to make a complete history. Current store fails to add the event into the watchhub, which causes issues.
|
@sycal Hi, actually can you give this patch a test? I tested this locally and it works. You need to create a fresh cluster that built with this patch. |
|
@xiang90 Yes, I applied your original fix earlier today to our source and initial tests seemed very positive (couldn't get it to fail). Will continue tomorrow morning with the full fix and report back. |
|
@sycal Thanks! We will do a release this friday with the fix. |
|
I've been doing more testing today and still haven't seen the error re-appear. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5442.
/cc @sycal
When using refresh, etcd store v2 watch is broken. Although with refresh
store should not trigger current watchers, it should still add events into
the watchhub to make a complete history. Current store fails to add the event
into the watchhub, which causes issues.