wal: release wal locks before renaming directory on init #5855
Conversation
| return nil, err | ||
| } | ||
|
|
||
| w.fp = newFilePipeline(w.dir, segmentSizeBytes) |
There was a problem hiding this comment.
Open will create the file pipeline
|
Thank you! I rebuilt coreos:master from source with this change in it, and it worked for me as well. Question: Other than cloning etc with your change and running build.bat, did you go through any other steps before building this on Windows? I've been looking for documentation on building via build.bat and haven't found anything (it clearly works, with some spurious "The directory name is invalid." build initialization errors that don't appear to affect the build itself). |
|
lgtm |
|
@MartyMacGyver just |
|
@heyitsanthony I'll investigate and then open an issue or two (the how-to-build docs and release notes could use some enhancements in regard to the right way to build and use this in Windows, including prerequisites (e.g., probably need NTFS if you expect to re-create symlinks with Junction calls). Thanks again for the quick turnaround on this bug! |
Brokenness of master on windows confirmed; works with patch.
Fixes #5852
/cc @xiang90 @MartyMacGyver