etcdserver: fix TestSnap #5885
Merged
etcdserver: fix TestSnap #5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. sorry, closed by clicking the wrong button. |
| @@ -869,7 +869,7 @@ func TestSnapshot(t *testing.T) { | |||
| if !reflect.DeepEqual(gaction[1], testutil.Action{Name: "SaveNoCopy"}) { | |||
| t.Errorf("action = %s, want SaveNoCopy", gaction[1]) | |||
| } | |||
| gaction = p.Action() | |||
| gaction, _ = p.Wait(1) | |||
There was a problem hiding this comment.
This is still racey. p would need to be NewStorageRecorderStream for this to be reliable.
|
@heyitsanthony fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5797.
We introduce the kv.commit call in the snapshot path, which slows down the go routine. Using wait to reliably wait for the actual snap event to happen.