-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: add basic upgrade tests #5906
Conversation
@@ -58,6 +58,7 @@ function unit_tests { | |||
|
|||
function integration_tests { | |||
echo "Running integration tests..." | |||
MIGRATION_FROM=v3.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be better with environmental variable. I put this just for this PR to test it in the CI.
255aa7f
to
4ead59a
Compare
@heyitsanthony @xiang90 Please review. This adds basic migration tests that I do manually for releases. |
@@ -57,7 +57,16 @@ function unit_tests { | |||
} | |||
|
|||
function integration_tests { | |||
echo "Running integration tests..." | |||
MIGRATION_TEST="v3.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably get the last release version from git (grep for version: bump
?)
overall seems like the right direction |
@heyitsanthony All addressed. Test can now run with PTAL. Thanks. |
|
||
// TestReleaseMigrate ensures that changes to master branch does not affect the | ||
// migration from latest etcd releases. | ||
func TestReleaseMigrate(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestReleaseUpgrade? this is not migration, right?
@xiang90 Just added Thanks! |
lgtm |
For coreos#5697.