Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdmain: only get initial cluster setting if the member is not initi… #5918

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Jul 11, 2016

fix #5444

@raoofm can you give this a try?

@raoofm
Copy link
Contributor

raoofm commented Jul 13, 2016

@xiang90 lgtm

backporting to v2?

@xiang90
Copy link
Contributor Author

xiang90 commented Jul 13, 2016

@raoofm Is there a reason that prevents you from upgrading to etcd 3.0? We will probably keep back-porting bug fixes to 2.3 branch until 3.0 is stable. But once we feel 3.0 is stable, we wont back port any.

@xiang90
Copy link
Contributor Author

xiang90 commented Jul 13, 2016

@heyitsanthony rebased. ptal.

@heyitsanthony
Copy link
Contributor

lgtm

@xiang90 xiang90 merged commit 071eac3 into etcd-io:master Jul 13, 2016
@xiang90 xiang90 deleted the init branch July 13, 2016 23:28
@raoofm
Copy link
Contributor

raoofm commented Jul 14, 2016

Is there a reason that prevents you from upgrading to etcd 3.0?

@xiang90 Nope, just waiting for v3 to stabilize as we are running in prod. Need to evaluate and plan the migration which seems a lot as a number of clients (java based) needs to be changed to support v3.

Oh wait, so as I read the v2-migration guide, I think there is no need to migrate the clients unless I want the clients to use v3 features. So even after upgrading, both v2 and v3 should be available and the clients should work as is. Right?

So upgrade of clients (read only) is not directly linked to upgrade of etcd from v2 to v3, and the write ones might need some planning (with/without downtime and migration mode) Right?

@xiang90
Copy link
Contributor Author

xiang90 commented Jul 14, 2016

So even after upgrading, both v2 and v3 should be available and the clients should work as is. Right?

Yes

So upgrade of clients (read only) is not directly linked to upgrade of etcd from v2 to v3, and the write ones might need some planning (with/without downtime and migration mode) Right?

You can still write to v2 after migration.

@raoofm
Copy link
Contributor

raoofm commented Jul 14, 2016

👏 great, thanks much @xiang90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

etcd does SRV look up for restart and then reads cluster file. It should do only 1 of file/SRV
4 participants