etcdserver: reject member removal that breaks active quorum #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if !s.cluster.IsReadyToRemoveMember(id) { | ||
| plog.Warningf("not enough started members, rejecting remove member %v", id) |
There was a problem hiding this comment.
%s", types.ID(id)), so that the log output format can be consistent with other hex ids?
|
awesome! lgtm. |
|
LGTM. Thanks! |
heyitsanthony
force-pushed
the
remove-member-quorum
branch
2 times, most recently
from
54852fb
to
aa9837e
Compare
|
Can we add release note label to this? This is a user facing change |
|
@xiang90 Just added. Will make sure we highlight this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.