Add a no-ttl flag to etcdctl migrate to discard keys on transform. #6793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hongchaodeng Can you please review this? |
hongchaodeng
reviewed
Nov 3, 2016
| @@ -42,6 +42,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| migrateNoTTL bool | |||
| @@ -55,6 +56,7 @@ func NewMigrateCommand() *cobra.Command { | |||
| Run: migrateCommandFunc, | |||
| } | |||
|
|
|||
| mc.Flags().BoolVar(&migrateNoTTL, "no-ttl", false, "Do not convert TTL keys") | |||
There was a problem hiding this comment.
I'm fine with the flag name.
Can you change the var to "migrateExcludeTTLKey"?
Merged
xiang90
reviewed
Nov 3, 2016
| @@ -311,6 +313,10 @@ func defaultTransformer() (io.WriteCloser, io.ReadCloser, chan error) { | |||
| return | |||
| } | |||
|
|
|||
| if migrateExcludeTTLKey && node.TTL != 0 { | |||
There was a problem hiding this comment.
we should move this to writeKey func, which emits the keys to transformer. or this flag only works for the default transformer.
|
Please also change the commit message to ctlv3: Add a no-ttl flag to etcdctl migrate to discard keys on transform. Or CI wont pass. |
|
LGTM. Will merge when CI turns green. |
|
/cc me |
|
@xiang90 - it seems that test passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6767
Adds a simple no-ttl flag to allow users to skip any ttl keys.