etcdserver: increase snapshot to 100,000 #7160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep more wal entries in memory for fast follower recovery. 10,000 was a too small number that triggers quite a few snapshots. ZK proves that 100,000 is a reasonable number for even old less prowerful machines. Eventually we should provide both count and max memory (for large entries).
|
/cc @heyitsanthony |
Current coverage is 63.85% (diff: 100%)
|
|
travis seems went crazy. |
|
lgtm. Could you open an issue about making this smarter in the future so it can be tracked? |
|
@heyitsanthony Sure. I will open an issue to track this and merge in this PR shortly. |
|
@heyitsanthony Created issue #7162 |
|
@gyuho we need to set snapshot count to 10,000 for our functional tester explicitly now. We do want to trigger snapshot sending fast in our functional tester. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep more wal entries in memory for fast follower recovery and less snapshots.
10,000 was a too small number that triggers quite a few compactions/snapshots.
ZK proves that 100,000 is a reasonable number for even old less powerful
machines.
Eventually we should provide both count and max memory (for large entries).