Dockerfile-release: add nsswitch.conf into image #7560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file '/etc/nsswitch.conf' is created in order to take in account '/etc/hosts' entries while resolving domain names.
gyuho
reviewed
Mar 22, 2017
| # but Golang relies on /etc/nsswitch.conf to check the order of DNS resolving | ||
| # (see https://github.com/golang/go/commit/9dee7771f561cf6aee081c0af6658cc81fac3918) | ||
| # To fix this we just create /etc/nsswitch.conf and add the following line: | ||
| RUN echo 'hosts: files mdns4_minimal [NOTFOUND=return] dns mdns4' >> /etc/nsswitch.conf |
There was a problem hiding this comment.
Can you explain why we do this order of files mdns4_minimal ...?
There was a problem hiding this comment.
It possibly traces back to gliderlabs/docker-alpine#11
It seems like this is the canonical workaround
There was a problem hiding this comment.
yep, it's kind of a 'default' order (at least in Ubuntu), and I found this explanation pretty good https://ubuntuforums.org/showthread.php?t=971693&p=12589927#post12589927
|
Confirm that this fixes the issue #7559. LGTM. Thanks! /cc @heyitsanthony |
gyuho
approved these changes
Mar 23, 2017
heyitsanthony
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file '/etc/nsswitch.conf' is created in order to
take in account '/etc/hosts' entries while resolving
domain names inside docker container.
Closes #7559