Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: refactor watch benchmark #8069

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

heyitsanthony
Copy link
Contributor

Hangs at/above 100 streams due to a hardcoded constant defaultMaxStreamsClient in grpc (having multiple grpc connections doesn't seem to make a difference)

Supersedes #7922, #8057

@heyitsanthony
Copy link
Contributor Author

OK, I was setting --conns but not --clients, so it can get above 100. Will add a warning in the benchmark if it's exceeding the limit.

@heyitsanthony heyitsanthony force-pushed the fix-watch-bench branch 2 times, most recently from 70162fa to 56db7e5 Compare June 9, 2017 04:11
@codecov-io
Copy link

Codecov Report

Merging #8069 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8069      +/-   ##
==========================================
- Coverage   76.66%   76.65%   -0.01%     
==========================================
  Files         341      341              
  Lines       26511    26511              
==========================================
- Hits        20324    20322       -2     
- Misses       4741     4743       +2     
  Partials     1446     1446
Impacted Files Coverage Δ
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
clientv3/namespace/watch.go 93.93% <0%> (-6.07%) ⬇️
pkg/adt/interval_tree.go 89.63% <0%> (-3.66%) ⬇️
etcdserver/api/v3election/election.go 64.7% <0%> (-2.95%) ⬇️
raft/node.go 90.17% <0%> (-2.24%) ⬇️
rafthttp/msgappv2_codec.go 71.3% <0%> (-1.74%) ⬇️
rafthttp/peer.go 90.22% <0%> (-1.51%) ⬇️
etcdserver/server.go 80.74% <0%> (-0.24%) ⬇️
clientv3/watch.go 96.25% <0%> (+0.75%) ⬆️
mvcc/watchable_store.go 88.75% <0%> (+0.77%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c073c...56db7e5. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tried it and works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants