Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafthttp: permit very large v2 snapshots #8074

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

heyitsanthony
Copy link
Contributor

v2 snapshots were hitting the 512MB message decode limit, causing
sending snapshots to new members to fail for being too big.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

Will backport both to 3.1 and 3.2 before release.

@gyuho gyuho added this to the v3.2.0 milestone Jun 9, 2017
@gyuho
Copy link
Contributor

gyuho commented Jun 9, 2017

c.f. #5386 (comment)

v2 snapshots were hitting the 512MB message decode limit, causing
sending snapshots to new members to fail for being too big.
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@56841bb). Click here to learn what that means.
The diff coverage is 45%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8074   +/-   ##
=========================================
  Coverage          ?   76.51%           
=========================================
  Files             ?      342           
  Lines             ?    26548           
  Branches          ?        0           
=========================================
  Hits              ?    20314           
  Misses            ?     4774           
  Partials          ?     1460
Impacted Files Coverage Δ
rafthttp/msg_codec.go 100% <100%> (ø)
integration/cluster_proxy.go 100% <100%> (ø)
rafthttp/http.go 77.1% <100%> (ø)
proxy/grpcproxy/adapter/auth_client_adapter.go 35.29% <35.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56841bb...9543431. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants