build-aci: Fix ACI image name #8090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The appc discovery spec states that the architecture specifier in the ACI image file name will be an ACI architecture value. Our build scripts were using GOARCH in the image name, which is incorrect for arm64/aarch64. See: https://github.com/appc/spec/blob/master/spec/discovery.md Fixes errors like these on arm64 machines: $ rkt --debug --insecure-options=image fetch coreos.com/etcd:v3.2.0-rc.1 image: remote fetching from URL "https://github.com/coreos/etcd/releases/download/v3.2.0-rc.1/etcd-v3.2.0-rc.1-linux-aarch64.aci" fetch: bad HTTP status code: 404 Signed-off-by: Geoff Levand <geoff@infradead.org>
Codecov Report
@@ Coverage Diff @@
## master #8090 +/- ##
==========================================
- Coverage 76.65% 76.43% -0.23%
==========================================
Files 342 342
Lines 26592 26568 -24
==========================================
- Hits 20384 20307 -77
- Misses 4759 4799 +40
- Partials 1449 1462 +13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appc discovery spec states that the architecture specifier in the ACI
image file name will be an ACI architecture value. Our build scripts were
using GOARCH in the image name, which is incorrect for arm64/aarch64.
See: https://github.com/appc/spec/blob/master/spec/discovery.md