v3rpc: Let clients establish unlimited streams #8238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yudai
force-pushed
the
allow_more_streams
branch
from
dde3bf9
to
c7c6aa4
Compare
heyitsanthony
approved these changes
Jul 11, 2017
From go-grpc v1.2.0, the number of max streams per client is set to 100 by default by the server side. This change makes it impossible for third party proxies and custom clients to establish many streams.
yudai
force-pushed
the
allow_more_streams
branch
from
c7c6aa4
to
52101e6
Compare
|
Done! |
yudai
changed the title
|
thanks! merging. |
Codecov Report
@@ Coverage Diff @@
## master #8238 +/- ##
========================================
Coverage ? 76.3%
========================================
Files ? 346
Lines ? 26994
Branches ? 0
========================================
Hits ? 20598
Misses ? 4914
Partials ? 1482
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Observed
From etcd v3.2.0, custom clients can create up to 100 streams for watch and keepalive. This limitation can cause unexpected behavior to custom clinets/proxies that need to establish many streams.
Issue Detail
etcd v3.2.0 updated the go-grpc library and it had a (breaking) change in it, which caps the default max streams per client to 100 (grpc/grpc-go#1071).
The official client and proxies do not establish many streams for now. However, this limitation can have impact for third party libraries that need to establish more streams for some reason.
Proposal
In this commit, we simply set the number of streams to the max number. We may have configuration property for this as well.