Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/health reports unhealthy when alarm is raised #8272

Merged
merged 2 commits into from
Jul 18, 2017
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jul 17, 2017

Fix #8207.

@gyuho gyuho changed the title /health reports unhealthy /health reports unhealthy when database space exceeded Jul 17, 2017
@heyitsanthony
Copy link
Contributor

Can this detect when etcd is in maintenance mode / has an alarm raised instead of exposing quota stuff? That way it'll be able to handle corruption alarms too...

@gyuho gyuho added the WIP label Jul 17, 2017
@gyuho gyuho changed the title /health reports unhealthy when database space exceeded /health reports unhealthy when alarm is raised Jul 17, 2017
@gyuho gyuho removed the WIP label Jul 18, 2017
@gyuho
Copy link
Contributor Author

gyuho commented Jul 18, 2017

@heyitsanthony PTAL. Thanks.

Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@@ -1667,3 +1667,7 @@ func (s *EtcdServer) goAttach(f func()) {
f()
}()
}

func (s *EtcdServer) ListAlarms() []*pb.AlarmMember {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alarms()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants