v3rpc: set Canceled=true on compacted watch #8283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
heyitsanthony
force-pushed
the
cancel-compact-rpc
branch
from
48dbeb0
to
9581f76
Compare
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Nov 14, 2017
Do not backport etcd-io#8283. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to the RPC needs client changes to avoid closing the channel without sending the compact revision; older clients will only see the close. Possible alternatives are either fake it entirely in the client, send two compact revision responses (one without the cancel, followed by one with), or change the documentation.
Fixes #8231