api: lease comparison target #8324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Jul 28, 2017
| // range_end compares the given target to all keys in the range [key, range_end). | ||
| // See RangeRequest for more details on key ranges. | ||
| bytes range_end = 8; | ||
| bytes range_end = 64; |
There was a problem hiding this comment.
this field is not in any release yet, right?
There was a problem hiding this comment.
right, caught it early
|
do we also need to update etcdctl? |
heyitsanthony
force-pushed
the
txn-cmp-lease
branch
from
067cc5a
to
68934a9
Compare
|
OK added etcdctl support |
|
lgtm |
Also shifts down fields following target_union in case there's any more reason to expand. OK since range_end is still pre-release.
heyitsanthony
force-pushed
the
txn-cmp-lease
branch
from
68934a9
to
341664f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to perform some atomic actions based on leases. For disconnected linearized reads, keys with ttls can't be easily leased since if the client is disconnected it doesn't know whether the ttl expires. Although there could be a Get in the leasing txn to later undo the leasing if the key turns out to have a ttl, this is inefficient and less reliable than gating it at the txn level.
I've omitted clientv3 support for the time being since calling the comparison function Lease to follow the current convention would conflict with the lease interface