clientv3: Disconnected Linearized Reads #8341
Conversation
clientv3/integration/leasing_test.go
Outdated
| "github.com/coreos/etcd/pkg/testutil" | ||
| ) | ||
|
|
||
| func TestLeasingPutGet1(t *testing.T) { |
There was a problem hiding this comment.
s/TestLeasingPutGet1/TestLeasingPutGet/? Or does 1 mean something?
There was a problem hiding this comment.
Oh no, it doesn't. Sorry, I forgot to edit the test names.
visheshnp
force-pushed
the
leasing-pr
branch
2 times, most recently
from
01384d7
to
7a9175e
Compare
|
@visheshnp can you fix the commit titles as well? |
visheshnp
force-pushed
the
leasing-pr
branch
2 times, most recently
from
e30025f
to
2ccbf65
Compare
Codecov Report
@@ Coverage Diff @@
## master #8341 +/- ##
=========================================
Coverage ? 77.16%
=========================================
Files ? 353
Lines ? 28019
Branches ? 0
=========================================
Hits ? 21621
Misses ? 4882
Partials ? 1516
Continue to review full report at Codecov.
|
|
@visheshnp lgtm once tests pass, but the commits that touch the |
clientv3/leasing/doc.go
Outdated
| // limitations under the License. | ||
|
|
||
| // Package leasing is a clientv3 wrapper that provides the client exclusive write access to a key by acquiring a lease and be lineraizably | ||
| // served locally. This leasing layer can either directly wrap the etcd client |
There was a problem hiding this comment.
single space between either and directly?
clientv3/leasing/doc.go
Outdated
| // //Output: 123 (served locally) | ||
| // | ||
| // Lease Revocation: | ||
| // If a client writes to the key owned by the leasing client, then the leasing client gives up its lease allowing the client to modify the key. |
There was a problem hiding this comment.
single space owned between by?
visheshnp
force-pushed
the
leasing-pr
branch
2 times, most recently
from
bae0d12
to
6391b8d
Compare
No description provided.