etcdctl: add ttl flag for lock command #8370
Conversation
jiaxuanzhou
changed the title
| @@ -28,13 +28,19 @@ import ( | |||
| "golang.org/x/net/context" | |||
| ) | |||
|
|
|||
| var ( | |||
| sessionTTL int | |||
There was a problem hiding this comment.
s/sessionTTL/lockTTL since there will probably be a electTTL eventually
There was a problem hiding this comment.
declared lockTTL , removed sessionTTL/defaultSessionTTL
| @@ -28,13 +28,19 @@ import ( | |||
| "golang.org/x/net/context" | |||
| ) | |||
|
|
|||
| var ( | |||
| sessionTTL int | |||
| defaultSessionTTL = 10 | |||
There was a problem hiding this comment.
don't have to declare this, just have lockTTL = 10?
| // NewLockCommand returns the cobra command for "lock". | ||
| func NewLockCommand() *cobra.Command { | ||
| c := &cobra.Command{ | ||
| Use: "lock <lockname> [exec-command arg1 arg2 ...]", | ||
| Short: "Acquires a named lock", | ||
| Run: lockCommandFunc, | ||
| } | ||
| c.Flags().IntVarP(&sessionTTL, "session-ttl", "t", defaultSessionTTL, "timeout for session") |
There was a problem hiding this comment.
modified to --ttl
here is the test:
$ ETCDCTL_API=3 ./etcdctl lock --help
NAME:
lock - Acquires a named lock
USAGE:
etcdctl lock [exec-command arg1 arg2 ...]
OPTIONS:
--ttl=10 timeout for session
|
@jiaxuanzhou one last bit: |
gyuho
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8370 +/- ##
=========================================
Coverage ? 76.98%
=========================================
Files ? 353
Lines ? 28115
Branches ? 0
=========================================
Hits ? 21643
Misses ? 4943
Partials ? 1529
Continue to review full report at Codecov.
|
1, add session ttl for lock cmd
2, set default session ttl to 10 seconds
@xiang90 @heyitsanthony
please buddy check and suggest if it is a better way to set the ttl as a gloabal flag ?