Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: upgrade grpc/grpc-go to v1.6.0 #8625

Merged
merged 1 commit into from
Sep 28, 2017
Merged

vendor: upgrade grpc/grpc-go to v1.6.0 #8625

merged 1 commit into from
Sep 28, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 28, 2017

grpc-go v1.6.0 has keepalive fix.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@gyuho gyuho added the WIP label Sep 28, 2017
@xiang90
Copy link
Contributor

xiang90 commented Sep 28, 2017

let's do the upgrade in one PR and adding test in another one?

@gyuho
Copy link
Contributor Author

gyuho commented Sep 28, 2017

@xiang90 Sure.

@gyuho gyuho changed the title [WIP] *: upgrade grpc-go to v1.6.0, add watch with client keepalive test vendor: upgrade grpc-go to v1.6.0 Sep 28, 2017
@xiang90
Copy link
Contributor

xiang90 commented Sep 28, 2017

lgtm if tests are passed

@gyuho gyuho changed the title vendor: upgrade grpc-go to v1.6.0 vendor: upgrade grpc/grpc-go to v1.6.0 Sep 28, 2017
@gyuho gyuho removed the WIP label Sep 28, 2017
@gyuho gyuho merged commit 55b7289 into etcd-io:master Sep 28, 2017
@gyuho gyuho deleted the kl branch September 28, 2017 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants