-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl/v3: enable 'require-leader' for 'watch' command #8672
Conversation
i think the require leader should probably be enabled for ctl tool. |
so no need the flag. |
You mean by default, enabled for watch? |
yes, enable by default for watch. etcdctl users would expect the command to be always interactive. it is probably the best option to simply enable require leader and do not provide that as a flag. |
To help with network partition cases. Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@xiang90 PTAL. |
lgtm |
Codecov Report
@@ Coverage Diff @@
## master #8672 +/- ##
=========================================
Coverage ? 76.01%
=========================================
Files ? 360
Lines ? 29643
Branches ? 0
=========================================
Hits ? 22533
Misses ? 5544
Partials ? 1566
Continue to review full report at Codecov.
|
Address #7941 (comment).