Automated cherry pick of #8427 to release 3.1 branch #8806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpbetz seems like ci does not like 3.1 release. |
|
Yeah, Semaphore doesn't support per-branch commands. We might need manually build release-3.1 test image and add |
|
Actually, if we are going to use Go 1.8.5 for release-3.1, we already have image. /cc @xiang90 |
|
Fixing with #8807. After that is merged I'll rebase this. |
jpbetz
force-pushed
the
automated-cherry-pick-of-#8427-origin-release-3.1-1509570173
branch
from
6bacf5b
to
e83f50e
Compare
|
this is ready to merge? /cc @jpbetz |
|
@xiang90, yes, this is now ready. |
|
It does? Did you mean PR title? Also 3.1 does check commit title https://github.com/coreos/etcd/blob/release-3.1/test#L202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8411
This is pending #8805, which requires approval before we merge any cherrypicks targeting the 3.1 branch. Submitting it now for testing.