Documentation/op-guide: Add rules for Prometheus 2.0 #8848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Nov 10, 2017
| changes within the last hour | ||
| summary: a high number of leader changes within the etcd cluster are happening | ||
| - alert: HighNumberOfFailedGRPCRequests | ||
| expr: sum(rate(etcd_grpc_requests_failed_total{job="etcd"}[5m])) BY (grpc_method) |
There was a problem hiding this comment.
Yes, I was going to do that in a subsequent PR, happy to do it here as well though.
There was a problem hiding this comment.
Yes, I was going to do that in a subsequent PR
Ok sounds good.
Can you file another PR?
Thanks!
xiang90
reviewed
Nov 13, 2017
| @@ -100,7 +100,7 @@ Now Prometheus will scrape etcd metrics every 10 seconds. | |||
|
|
|||
| ### Alerting | |||
|
|
|||
| There is a [set of default alerts for etcd v3 clusters](./etcd3_alert.rules). | |||
| There is a set of default alerts for etcd v3 clusters for [Prometheus 1.x](./etcd3_alert.rules) as well as [Prometheus 2.x](./etcd3_alert.rules). | |||
There was a problem hiding this comment.
You're absolutely right. I'll fix it with the follow-up PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the existing Prometheus alerting rules in the new Prometheus 2.0 rule syntax.
@xiang90 @gyuho