Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compactor: fix error message of Revision compactor #8999

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

yudai
Copy link
Contributor

@yudai yudai commented Dec 11, 2017

Hello,

This is just a quick fix for an error message formatting. The Periodic compactor does not have the same issue.


Reorder the parameters so that Noticef can output the error properly.

Reorder the parameters so that Noticef can output the error properly.
@xiang90
Copy link
Contributor

xiang90 commented Dec 11, 2017

lgtm. thanks.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@809b0d7). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8999   +/-   ##
=========================================
  Coverage          ?   76.05%           
=========================================
  Files             ?      359           
  Lines             ?    29825           
  Branches          ?        0           
=========================================
  Hits              ?    22682           
  Misses            ?     5561           
  Partials          ?     1582
Impacted Files Coverage Δ
compactor/revision.go 69.04% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809b0d7...06365b6. Read the comment docs.

@xiang90 xiang90 merged commit b52856d into etcd-io:master Dec 11, 2017
gyuho added a commit that referenced this pull request Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants