Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcproxy: configure --max-send-bytes and --max-recv-bytes for grpc proxy #9250

Merged
merged 2 commits into from
Jan 30, 2018

Conversation

zbindenren
Copy link
Contributor

Hi

Pull request which solves #9055 for grpc-proxy.

@zbindenren zbindenren changed the title configure --max-send-bytes and --max-recv-bytes for grpc proxy grpcproxy: configure --max-send-bytes and --max-recv-bytes for grpc proxy Jan 30, 2018
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@gyuho gyuho merged commit 73e020d into etcd-io:master Jan 30, 2018
@@ -115,6 +117,8 @@ func newGRPCProxyStartCommand() *cobra.Command {
cmd.Flags().StringVar(&grpcProxyNamespace, "namespace", "", "string to prefix to all keys for namespacing requests")
cmd.Flags().BoolVar(&grpcProxyEnablePprof, "enable-pprof", false, `Enable runtime profiling data via HTTP server. Address is at client URL + "/debug/pprof/"`)
cmd.Flags().StringVar(&grpcProxyDataDir, "data-dir", "default.proxy", "Data directory for persistent data")
cmd.Flags().IntVar(&grpcMaxCallSendMsgSize, "max-send-bytes", 1.5*1024*1024, "message send limits in bytes (default value is 1.5 MiB)")
Copy link
Contributor

@xiang90 xiang90 Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.5*1024*1024 should be defined as a const rather than a inline number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants