etcdserver: improve request took too long warning #9288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyuho probably we can backport this small improvement to 3.3 as well. it is helpful for debugging purpose. |
|
@xiang90 Ack. And lgtm. Thanks. |
|
@jpbetz not sure if k8s cluster can hit this warning frequently. if it is, i suggest to backport this to 3.1 as well to help users to debug. |
|
/cc @WIZARD-CXY |
|
@xiang90 lgtm will populate test ENV this evening, thanks. |
gyuho
approved these changes
Feb 6, 2018
|
ack. |
jpbetz
added a commit
to jpbetz/etcd
that referenced
this pull request
Jun 7, 2018
gyuho
referenced
this pull request
Jun 12, 2018
…rigin-release-3.2 Automated cherry pick of detailed "took too long" warnings to release-3.2
jpbetz
added a commit
to jpbetz/etcd
that referenced
this pull request
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9111
range and txn readonly range need special care in its own funcs since these two kinds of request wont go through raft to be applied.
example output
to trigger the warning, try to put 1M keys into etcd and do a large range over the entire 1M keys.
/cc @hexfusion please take a look. thanks!