Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build site in CI #357

Open
bgilbert opened this issue Feb 11, 2022 · 6 comments
Open

Build site in CI #357

bgilbert opened this issue Feb 11, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bgilbert
Copy link
Contributor

PR CI should run ./build.sh, upload the artifacts somewhere browsable, and post a link in the PR.

@bgilbert bgilbert added enhancement New feature or request good first issue Good for newcomers labels Feb 11, 2022
@RishiKumarRay
Copy link

I would like to try this

@bgilbert
Copy link
Contributor Author

Great! For security, GitHub recommends splitting privileged jobs like this into two pieces, similar to this and this.

@dustymabe, is there a good place we could upload staging content? Maybe we could create an S3 bucket and a token with write access to it?

@travier
Copy link
Member

travier commented Feb 11, 2022

We could maybe enable GitHub pages here and push to a docs branch with a subpath based on PR number.

@bgilbert
Copy link
Contributor Author

I'd rather not fill the production repo with a bunch of test builds. If we want to go the GitHub Pages route, maybe we could create a dedicated repo for that. Even then, it seems a bit awkward for CI runs to live in long-term Git history.

@travier
Copy link
Member

travier commented Feb 21, 2022

It's also fairly easy to setup GitHub Pages for a forked repo: https://github.com/coreos/fedora-coreos-tracker/blob/main/docs/testing-project-documentation-changes.md

@travier
Copy link
Member

travier commented Feb 21, 2022

I'd rather not fill the production repo with a bunch of test builds. If we want to go the GitHub Pages route, maybe we could create a dedicated repo for that. Even then, it seems a bit awkward for CI runs to live in long-term Git history.

I agree that having a dedicated testing repo would make sense and would simplify the permission setup while keeping the production repo clean. We could do a periodic cleanup of old branches but I don't think it really matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants