-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os-extensions: vim is not a good example #396
Comments
@bgilbert Please take the time to provide a reason for closing, should you chose to close it again. |
Thanks for rewording the issue description. vim is a simple example, but I agree that it's not a great one for the reasons you mentioned. If you'd like to work on this yourself, we'd certainly accept a PR with a more complex example. (Of the ones you mentioned, OpenVPN seems the least controversial.) Otherwise, we may not get to this soon, but it'll hopefully be addressed in due course. |
Thank you for your comments! What's your take on ZFS vis-a-vis OpenVPN as an example? |
This particular OS Extensions example is useful because we did change the default text editor (as Fedora did) to
I think the goal is to keep the example simple. If we were to change it or add a new example I'd probably keep ZFS out of it and just stick with OpenVPN. |
I would prefer we add a new example and keep this one. As Dusty said, we need this specific example to point people to when then need vim and not vi/nano. |
👍 to adding an additional example. ZFS would work (and is arguably a better example than OpenVPN), with one caveat: it'd need to be |
I believe VIM is an extremely poor example that, if anything, undercuts the pro-containers message the documentation as a whole is trying to make, for these reasons:
--security-opt label=disable
when bind-mounting host's directory into a container. I suspect you could edit just about any file on the system by running a VIM container, bind-mounting the directory that contains the file, and using the aforementioned--security-opt label=disable
.Please replace VIM with an example that makes sense in the context this page is trying to illustrate.
Here are some suggestions:
The text was updated successfully, but these errors were encountered: