Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os-extensions: vim is not a good example #396

Open
zhenya-1007 opened this issue Apr 14, 2022 · 6 comments
Open

os-extensions: vim is not a good example #396

zhenya-1007 opened this issue Apr 14, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zhenya-1007
Copy link

zhenya-1007 commented Apr 14, 2022

I believe VIM is an extremely poor example that, if anything, undercuts the pro-containers message the documentation as a whole is trying to make, for these reasons:

  • It's a prototypical user-space program.
  • It is not hard to containerize: look at https://github.com/troglobit/mg for an example of editor-in-a-container; podman documentation suggests --security-opt label=disable when bind-mounting host's directory into a container. I suspect you could edit just about any file on the system by running a VIM container, bind-mounting the directory that contains the file, and using the aforementioned --security-opt label=disable.
  • If one must needs have vim on the machine, it is simple enough to install VIM below /var/usrlocal. This is something that can be done from a container with a couple of bind-mounts (and potentially with relabeling /var/usrlocal afterwards, as Redhat's very own documentation for Fedora Server suggests.

Please replace VIM with an example that makes sense in the context this page is trying to illustrate.

Here are some suggestions:

  • OpenVPN. Yes, Wireguard is arguably technically superior, but there may be organizations that cannot migrate for a while.
  • An out-of-tree driver. Maybe one of the WiFi cards from BrosTrend (yes, it's a bit silly -- but not nearly as silly as VIM). Or maybe a driver for a popular optical fibre network adapter? (no idea if all of those are in-tree these days). Or a GPU driver for AI workloads? (again, no idea if all the popular ones are in-tree these days).
  • NixOS or GNU Guix? (again, not the most convincing example -- but way more convincing than VIM, IMO).
@zhenya-1007 zhenya-1007 changed the title [main] Doc issue in file modules/ROOT/pages/os-extensions.adoc: seriously, vim?! [main] Doc issue in file modules/ROOT/pages/os-extensions.adoc: why VIM? Apr 15, 2022
@zhenya-1007
Copy link
Author

@bgilbert Please take the time to provide a reason for closing, should you chose to close it again.

@bgilbert bgilbert changed the title [main] Doc issue in file modules/ROOT/pages/os-extensions.adoc: why VIM? os-extensions: vim is not a good example Apr 15, 2022
@bgilbert bgilbert added the good first issue Good for newcomers label Apr 15, 2022
@bgilbert
Copy link
Contributor

Thanks for rewording the issue description. vim is a simple example, but I agree that it's not a great one for the reasons you mentioned. If you'd like to work on this yourself, we'd certainly accept a PR with a more complex example. (Of the ones you mentioned, OpenVPN seems the least controversial.) Otherwise, we may not get to this soon, but it'll hopefully be addressed in due course.

@zhenya-1007
Copy link
Author

Thank you for your comments! What's your take on ZFS vis-a-vis OpenVPN as an example?

@dustymabe
Copy link
Member

This particular OS Extensions example is useful because we did change the default text editor (as Fedora did) to nano and so we can point people at this when they want to switch it back, though arguably we could move that bit to a different section and just show setting $EDITOR to vi and not the layering vim part.

Thank you for your comments! What's your take on ZFS vis-a-vis OpenVPN as an example?

I think the goal is to keep the example simple. If we were to change it or add a new example I'd probably keep ZFS out of it and just stick with OpenVPN.

@travier
Copy link
Member

travier commented Apr 19, 2022

I would prefer we add a new example and keep this one. As Dusty said, we need this specific example to point people to when then need vim and not vi/nano.

@bgilbert
Copy link
Contributor

👍 to adding an additional example. ZFS would work (and is arguably a better example than OpenVPN), with one caveat: it'd need to be zfs-fuse rather than an implementation with a CDDL-licensed kernel module. Fedora doesn't ship the ZFS kernel module due to CDDL/GPL incompatibility, and I don't think we should officially document a combination that Fedora can't ship.

@travier travier added the enhancement New feature or request label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants