Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-koji-tagger: should be more resilient to builds taking long to get signed #138

Open
jlebon opened this issue Jun 14, 2021 · 1 comment

Comments

@jlebon
Copy link
Member

jlebon commented Jun 14, 2021

Sometimes Robosignatory is really backed up (e.g. if texlive) and it could take a while for the builds to be signed. Instead of just waiting 10 mins, since we're a persistent service we should just asynchronously wait forever until the builds are signed so that we can issue the follow-up distRepo.

@dustymabe
Copy link
Member

I think I was originally against waiting forever, especially since the next run would pick it up anyway. If it failed (rather than wait forever) and we actually had some sort of notification system set up then we could investigate.

I could see the argument for making it wait forever (or even just wait much longer), but am interested in specifically what problem we're trying to solve?

I often see pipeline builds fail because the tagger (signing/distrepo) took too long. Would be nice if we could make those wait if there is an existing distrepo running or something. I guess that won't really solve the signing problem either. Maybe:

pipeline build wait until:

  • no packages in "fXX-signing-pending" tag
  • an existing distrepo task completes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants