Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker group configuration #256

Closed
chrisweeksnz opened this issue Aug 19, 2019 · 5 comments
Closed

docker group configuration #256

chrisweeksnz opened this issue Aug 19, 2019 · 5 comments

Comments

@chrisweeksnz
Copy link

Issue

The Fedora CoreOS tech preview has a docker group added, but configured so that users can't be added to it. The group appears to exist in /etc/gshadow, but not in /etc/group. This may be intentional as a method to discourage users from using the docker group (considering it's security risk profile), but likewise it could be a bug.

Workaround

echo "$(getent group docker)" >> /etc/group

This restores normal function to the docker group. (eg. usermod -aG docker myusername will grant access to the docker daemon).

rpm-ostree status

$ sudo rpm-ostree status
State: idle
AutomaticUpdates: disabled
Deployments:
* ostree://fedora:fedora/x86_64/coreos/testing
                   Version: 30.20190801.0 (2019-08-01T13:54:21Z)
                    Commit: a9c8d66d3628d1b9b4c4690777e8b730d08329b4359410cb410a2003296af1ca
              GPGSignature: Valid signature by F1D8EC98F241AAF20DF69420EF3C111FCFC659B9
@lucab
Copy link
Contributor

lucab commented Aug 19, 2019

Thanks for the report. I do believe this is just a plain bug, but I'm not sure if it is due to the moby package or to the group handling logic in rpm-ostree.

@lucab
Copy link
Contributor

lucab commented Aug 26, 2019

The current moby-engine specfile has the following:

%pre
getent group %{service_name} >/dev/null || groupadd -r %{service_name} || :

I fear the last ||: may be swallowing some interesting errors in this case.

@lucab lucab closed this as completed Aug 26, 2019
@lucab lucab reopened this Aug 26, 2019
@lucab
Copy link
Contributor

lucab commented Aug 27, 2019

@dustymabe
Copy link
Member

this looks more like coreos/rpm-ostree#1318 which is a dup of coreos/rpm-ostree#49

@dustymabe
Copy link
Member

This acute issue should be fixed by coreos/fedora-coreos-config#175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants