Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F32: should we switch to cgroups v2 #373

Closed
dustymabe opened this issue Feb 5, 2020 · 6 comments
Closed

F32: should we switch to cgroups v2 #373

dustymabe opened this issue Feb 5, 2020 · 6 comments

Comments

@dustymabe
Copy link
Member

We originally decided to stay on cgroups v1 so that the container ecosystem could catch up. We should evaluate if we can move to cgroups v2 for the Fedora 32 rebase. Some examples of things to investigate:

  • can moby-engine upstream support cgroups v2 yet (assigned to @jlebon)
  • can we get a rebase of moby-engine to the latest release in rawhide? (assigned to @mike-nguyen to ask maintainers)
  • what is the state of kubernetes when it comes to cgroups v2?
@dustymabe
Copy link
Member Author

this ticket is related to: #372

@LorbusChris
Copy link
Contributor

cc'ing @vrutkovs for that 3rd bullet point :)

@vrutkovs
Copy link
Member

vrutkovs commented Feb 6, 2020

what is the state of kubernetes when it comes to cgroups v2?

cgroupvs2 can be used, but it requires kubernetes/enhancements#1370 (kubernetes/kubernetes#85218), few crio fixes (merged in master already afaik) and swapping runc with crun (afaik runc is planning to support cgroupsv2). @giuseppe would know more details

on OKD side we're safe because bootstrap / masters / workers switch to cgroupsv1 mode on pivot, so we're independent on defaults here

@giuseppe
Copy link

giuseppe commented Feb 6, 2020

the plan is to have cgroups v2 Alpha support for Kubernetes 1.19.

@AkihiroSuda
Copy link

Moby already has a basic support for cgroup2, but docker stats still remains unimplemented due to a Go mod hell: moby/moby#40360

@dustymabe dustymabe added the meeting topics for meetings label Feb 7, 2020
@dustymabe
Copy link
Member Author

We discussed during the meeting today

It appears that the moby and kubernetes projects are not quite there yet with regards to cgroups v2 support. In the meeting we proposed and agreed that we should probably wait for now:

11:57:56      dustymabe | #agreed while the container ecosystem is maturing, 
                          both moby (docker) and kubernetes aren't yet to a place 
                          where we're comfortable moving to cgroups v2 by default for
                          F32 based FCOS, we'll consider again at a later time

@dustymabe dustymabe removed the meeting topics for meetings label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants