unit: try to avoid unit file modification #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayrus
force-pushed
the
kayrus/dont_skip_empty_sections
branch
from
9bb6d77
to
fbfeef4
Compare
kayrus
force-pushed
the
kayrus/dont_skip_empty_sections
branch
from
fbfeef4
to
d88a86d
Compare
|
@kayrus I definitely appreciate the sentiment, but I'm a little ambivalent about this just being a partial promise, since as you note we still ignore comments. (personally, I regret the unit code ever went down the lexing path, since it's caused us so many problems :/). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonboulle it still skips commented strings, not sure how can I implement that...
main goal is to keep unit files unmodified when it is possible.
resolves coreos/fleet#1539