This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: add -output to journal #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tixxdz my concern is that then we're still then chasing journal arguments. What about just saying that it's passed through unaltered and hence supports whatever journalctl does? |
tixxdz
force-pushed
the
tixxdz/fleet-01-02-2016
branch
from
91bd02b
to
fcb0232
Compare
|
@jonboulle yes makes sense, ok updated. Thanks! |
| @@ -47,6 +48,7 @@ func init() { | |||
| cmdJournal.Flags.BoolVar(&flagFollow, "f", false, "Shorthand for --follow") | |||
| cmdJournal.Flags.IntVar(&sharedFlags.SSHPort, "ssh-port", 22, "Connect to remote hosts over SSH using this TCP port") | |||
| cmdJournal.Flags.BoolVar(&flagSudo, "sudo", false, "Execute journal command with sudo") | |||
| cmdJournal.Flags.StringVar(&flagOutput, "output", "short", "Journalctl output mode") | |||
There was a problem hiding this comment.
can we make this
"Output mode. This will be passed unaltered to journalctl on the remote host, and hence supports the same modes as that command."
|
LGTM after one suggested change |
This adds the --output flag to journal, which is passed through to journalctl, so that you can specify its output format. Fixes coreos#1398 Original-patch-by: Roy van de Water <roy.vwater@gmail.com>
tixxdz
force-pushed
the
tixxdz/fleet-01-02-2016
branch
from
fcb0232
to
f0549d6
Compare
tixxdz
added a commit
that referenced
this pull request
Feb 10, 2016
fleetctl: add -output to journal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the --output flag to journal, which is passed through
to journalctl, so that you can specify its output format.
Fixes #1398
Improved-by: Djalal Harouni djalal@endocode.com